linux-kernel - [PATCH] dax: Fix wrong error-number passed into xas_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200729034436.24267-1-lihao2018.fnst@cn.fujitsu.com>
Date:   Wed, 29 Jul 2020 11:44:36 +0800
From:   Hao Li <lihao2018.fnst@...fujitsu.com>
To:     <viro@...iv.linux.org.uk>
CC:     <dan.j.williams@...el.com>, <willy@...radead.org>, <jack@...e.cz>,
        <linux-fsdevel@...r.kernel.org>, <linux-nvdimm@...ts.01.org>,
        <linux-kernel@...r.kernel.org>, <lihao2018.fnst@...fujitsu.com>
Subject: [PATCH] dax: Fix wrong error-number passed into xas_set_err()

The error-number passed into xas_set_err() should be negative. Otherwise,
the xas_error() will return 0, and grab_mapping_entry() will return the
found entry instead of a SIGBUS error when the entry is not a value.
And then, the subsequent code path would be wrong.

Signed-off-by: Hao Li <lihao2018.fnst@...fujitsu.com>
---
 fs/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/dax.c b/fs/dax.c
index 11b16729b86f..acac675fe7a6 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -488,7 +488,7 @@ static void *grab_mapping_entry(struct xa_state *xas,
 		if (dax_is_conflict(entry))
 			goto fallback;
 		if (!xa_is_value(entry)) {
-			xas_set_err(xas, EIO);
+			xas_set_err(xas, -EIO);
 			goto out_unlock;
 		}
 
-- 
2.28.0