linux-kernel - Re: [PATCH] habanalabs: fix up absolute include instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Jul 2020 07:58:04 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     linux-kernel@...r.kernel.org, Oded Gabbay <oded.gabbay@...il.com>,
        Omer Shpigelman <oshpigelman@...ana.ai>,
        Tomer Tayar <ttayar@...ana.ai>,
        Moti Haimovski <mhaimovski@...ana.ai>,
        Ofir Bitton <obitton@...ana.ai>,
        Ben Segal <bpsegal20@...il.com>,
        Christine Gharzuzi <cgharzuzi@...ana.ai>,
        Pawel Piskorski <ppiskorski@...ana.ai>
Subject: Re: [PATCH] habanalabs: fix up absolute include instructions

On Wed, Jul 29, 2020 at 08:09:38AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Tue, 28 Jul 2020 19:18:51 +0200 Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> >
> > diff --git a/drivers/misc/habanalabs/common/Makefile b/drivers/misc/habanalabs/common/Makefile
> > index 97d03b5c8683..b984bfa4face 100644
> > --- a/drivers/misc/habanalabs/common/Makefile
> > +++ b/drivers/misc/habanalabs/common/Makefile
> > @@ -1,6 +1,4 @@
> >  # SPDX-License-Identifier: GPL-2.0-only
> > -subdir-ccflags-y += -I$(src)/common
> 
> I've seen oter places use
> 
> subdir-ccflags-y += -I$(srcdir)/$(src)/common
> 
> which would probably work as well.  i.e. just change this in the
> Makefiles rather than every source file.

I hate seeing odd ccflags stuff in Makefiles as it can catch you "by
surprise" as to what exactly is happening when looking at .c code.

But yes, your change would also work.

thanks,

greg k-h