linux-kernel - Re: [PATCH] reset: Fix and extend kerneldoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd98ed496cedfceec3d41064e95f05b8d3adcca1.camel@pengutronix.de>
Date:   Wed, 29 Jul 2020 08:41:21 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Krzysztof Kozlowski <krzk@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: Fix and extend kerneldoc

Hi Krzysztof,

On Tue, 2020-07-28 at 19:10 +0200, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
> 
>     drivers/reset/core.c:50: warning: Function parameter or member 'array' not described in 'reset_control'
>     drivers/reset/core.c:50: warning: Function parameter or member 'deassert_count' not described in 'reset_control'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/reset/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 01c0c7aa835c..a2df88e90011 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -32,7 +32,8 @@ static LIST_HEAD(reset_lookup_list);
>   * @refcnt: Number of gets of this reset_control
>   * @acquired: Only one reset_control may be acquired for a given rcdev and id.
>   * @shared: Is this a shared (1), or an exclusive (0) reset_control?
> - * @deassert_cnt: Number of times this reset line has been deasserted
> + * @array: Is this an array of reset controls (1)?
> + * @deassert_count: Number of times this reset line has been deasserted
>   * @triggered_count: Number of times this reset line has been reset. Currently
>   *                   only used for shared resets, which means that the value
>   *                   will be either 0 or 1.

Thank you for the fix, applied to reset/next.

regards
Philipp