linux-kernel - Re: [PATCH 3/3] tty: Use the preferred form for passing the size of a structure type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68c3dff9-816c-fb45-3af5-015be2443159@kernel.org>
Date:   Wed, 29 Jul 2020 09:55:29 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3/3] tty: Use the preferred form for passing the size of a
 structure type

On 24. 07. 20, 0:34, Gustavo A. R. Silva wrote:
> Use the preferred form for passing the size of a structure type. The
> alternative form where the structure type is spelled out hurts
> readability and introduces an opportunity for a bug when the object
> type is changed but the corresponding object identifier to which the
> sizeof operator is applied is not.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
Acked-by: Jiri Slaby <jirislaby@...nel.org>

The other 2 ones are already acked by me.

thanks,
-- 
js