linux-kernel - Re: [PATCH v3 1/3] arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1596010221.23124.2.camel@mtksdaap41>
Date:   Wed, 29 Jul 2020 16:10:21 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     Seiya Wang <seiya.wang@...iatek.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        <devicetree@...r.kernel.org>, <srv_heupstream@...iatek.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-serial@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/3] arm64: dts: Add Mediatek SoC MT8192 and
 evaluation board dts and Makefile

Hi, Seiya:

On Wed, 2020-07-29 at 16:02 +0800, CK Hu wrote:
> Hi, Seiya:
> 
> On Wed, 2020-07-29 at 09:30 +0800, Seiya Wang wrote:
> > Add basic chip support for Mediatek MT8192
> > 
> > Signed-off-by: Seiya Wang <seiya.wang@...iatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/Makefile       |   1 +
> >  arch/arm64/boot/dts/mediatek/mt8192-evb.dts |  29 ++
> >  arch/arm64/boot/dts/mediatek/mt8192.dtsi    | 671 ++++++++++++++++++++++++++++
> >  3 files changed, 701 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-evb.dts
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > 
> 
> [snip]
> 
> > +
> > +		watchdog: watchdog@...07000 {
> > +			compatible = "mediatek,mt6589-wdt";
> 
> According to [1] and [2], compatible string for mt8192 watch dog should
> be "mediatek,mt6873-wdt","mediatek,mt8192-wdt".
> 
> 
> [1]
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2287090/12
> [2]
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2131598/18
> 
> > +			reg = <0 0x10007000 0 0x100>;
> > +			#reset-cells = <1>;
> > +		};
> > +
> 
> [snip]
> 
> > +
> > +		mmsys: mmsys@...00000 {
> > +			compatible = "mediatek,mt8192-mmsys", "syscon";
> 
> You should define "mediatek,mt8192-mmsys" first, then you could use it
> in this patch

Sorry, this series depend on [1], but mmsys is a syscon, so this should
be

mmsys: syscon@...00000 {

[1]
http://lists.infradead.org/pipermail/linux-mediatek/2020-July/014451.html

Regards,
CK
> .
> 
> Regards,
> CK
> 
> > +			reg = <0 0x14000000 0 0x1000>;
> > +			#clock-cells = <1>;
> > +		};
> > +
>