linux-kernel - Re: [PATCH] ethernet: fix potential memory leak in gemini_ethernet_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c9c7e5a3-4909-e0c9-1c69-0ad3643ca3f5@web.de>
Date:   Wed, 29 Jul 2020 10:38:37 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Lu Wei <luwei32@...wei.com>, linux-arm-kernel@...ts.infradead.org,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>
Subject: Re: [PATCH] ethernet: fix potential memory leak in
 gemini_ethernet_port_probe()

> If some processes in gemini_ethernet_port_probe() fail,
> free_netdev(dev) needs to be called to avoid a memory leak.

Would you like to use an imperative wording for this change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6ba1b005ffc388c2aeaddae20da29e4810dea298#n151


…
> +++ b/drivers/net/ethernet/cortina/gemini.c
> @@ -2501,8 +2513,10 @@  static int gemini_ethernet_port_probe(struct platform_device *pdev)
>  					IRQF_SHARED,
>  					port_names[port->id],
>  					port);
> -	if (ret)
> +	if (ret) {
> +		free_netdev(netdev);
>  		return ret;
> +	}
>
>  	ret = register_netdev(netdev);
…

I suggest to add a jump target for the desired exception handling
in this function implementation.

 	if (ret)
-		return ret;
+		goto free_netdev;

Regards,
Markus