linux-kernel - Re: [PATCH v1 1/2] kernel: time: export sched_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pn8ea3o0.fsf@nanos.tec.linutronix.de>
Date:   Wed, 29 Jul 2020 14:47:43 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Freddy Hsin <freddy.hsin@...iatek.com>,
        linux-mediatek@...ts.infradead.or,
        linux-arm-kernel@...ts.infradead.org,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        Paul Cercueil <paul@...pouillou.net>,
        "Ben Dooks \(Codethink\)" <ben.dooks@...ethink.co.uk>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Saravana Kannan <saravanak@...gle.com>,
        linux-kernel@...r.kernel.org, chang-an.chen@...iatek.com,
        Baolin Wang <baolin.wang7@...il.com>,
        wsd_upstream@...iatek.com, kuohong.wang@...iatek.com,
        stanley.chu@...iatek.com, Freddy Hsin <freddy.hsin@...iatek.com>
Subject: Re: [PATCH v1 1/2] kernel: time: export sched_clock_register function

Freddy,

Freddy Hsin <freddy.hsin@...iatek.com> writes:

please do not come up with random prefixes. Just look at the topmost two
commits on that file:

2c8bd58812ee ("time/sched_clock: Expire timer in hardirq context")
2707745533d6 ("time/sched_clock: Disable interrupts in sched_clock_register()")

Also the sentence after the colon starts with an uppercase letter.

Please change 'sched_clock_register function' to
'sched_clock_register()' which makes it clear that this is a function

> export sched_clock_register function, because the Mediatek timer
> loadable module depends on this function

Again sentences start with an uppercase letter. Also the reason for
exporting this is wrong. There is no mediatek timer module now.

The point of exporting this (if at all) is that it's required for any
ARM SoC timer driver to be modularized.
> @@ -239,6 +239,7 @@ static enum hrtimer_restart sched_clock_poll(struct hrtimer *hrt)
>  
>  	pr_debug("Registered %pS as sched_clock source\n", read);
>  }
> +EXPORT_SYMBOL(sched_clock_register);

EXPORT_SYMBOL_GPL() please.

Thanks,

        tglx