linux-kernel - Re: [PATCH -next] habanalabs: make some functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Jul 2020 18:02:36 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Hulk Robot <hulkci@...wei.com>,
        Oded Gabbay <oded.gabbay@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Omer Shpigelman <oshpigelman@...ana.ai>,
        Ofir Bitton <obitton@...ana.ai>,
        Tomer Tayar <ttayar@...ana.ai>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] habanalabs: make some functions static

On Wed, Jul 29, 2020 at 11:59:25PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: warning:
>  symbol 'gaudi_ctx_init' was not declared. Should it be static?
> drivers/misc/habanalabs/goya/goya.c:5228:5: warning:
>  symbol 'goya_ctx_init' was not declared. Should it be static?
> 
> Those functions are not used outside of source file, so this
> commit marks them static.
> 
> Fixes: a04b7cd97eef ("habanalabs: create internal CB pool")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

0-day already sent this patch in earlier today, sorry.

greg k-h