linux-kernel - RE: [PATCH] hv_utils: Add validation for untrusted Hyper-V values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR21MB083600994098D204DF141AB3CC700@BN6PR21MB0836.namprd21.prod.outlook.com>
Date:   Wed, 29 Jul 2020 16:22:18 +0000
From:   Stephen Hemminger <sthemmin@...rosoft.com>
To:     Andres Beltran <lkmlabelt@...il.com>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Andrea Parri <parri.andrea@...il.com>,
        Saruhan Karademir <skarade@...rosoft.com>
Subject: RE: [PATCH] hv_utils: Add validation for untrusted Hyper-V values

Ok at least use the ratelimit form of kernel logging.

Netdev_err_ratelimited...

-----Original Message-----
From: Andres Beltran <lkmlabelt@...il.com> 
Sent: Wednesday, July 29, 2020 9:10 AM
To: Stephen Hemminger <sthemmin@...rosoft.com>
Cc: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>; Wei Liu <wei.liu@...nel.org>; linux-hyperv@...r.kernel.org; linux-kernel@...r.kernel.org; Michael Kelley <mikelley@...rosoft.com>; Andrea Parri <parri.andrea@...il.com>; Saruhan Karademir <skarade@...rosoft.com>
Subject: Re: [PATCH] hv_utils: Add validation for untrusted Hyper-V values

On Tue, Jul 28, 2020 at 5:04 PM Stephen Hemminger
<sthemmin@...rosoft.com> wrote:
>
> You may want to use one of the macros that prints this once only.
> This is a "should never happen" type error, so if something goes wrong it might happens so much that journal/syslog would get overloaded.

Certainly, printing error messages once would be ideal if we were only
dealing with Linux kernel bugs. But under the assumption that Hyper-V
can send bogus values at any time, I think it would be better to print
error messages every time so that we are aware of malicious/erroneous
data sent by the host.