linux-kernel - Re: [PATCH 2/7] ARM: s3c64xx: Include header to fix -Wmissing-prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Ln22EMWTRu4j-6b5Oj63Yvo+GYa_cB2+QU-h-woQ5G1K5DJw@mail.gmail.com>
Date:   Wed, 29 Jul 2020 19:46:04 +0200
From:   Tomasz Figa <tomasz.figa@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Russell King <linux@...linux.org.uk>,
        Kukjin Kim <kgene@...nel.org>,
        Vincent Sanders <vince@...tec.co.uk>,
        Simtec Linux Team <linux@...tec.co.uk>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:SAMSUNG SOC CLOCK DRIVERS" 
        <linux-samsung-soc@...r.kernel.org>,
        linux-stm32@...md-mailman.stormreply.com,
        patches@...nsource.cirrus.com,
        "open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>,
        linux-watchdog@...r.kernel.org,
        Sergio Prado <sergio.prado@...abworks.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Sylwester Nawrocki <snawrocki@...nel.org>,
        Cedric Roux <sed@...e.fr>, Lihua Yao <ylhuajnu@...look.com>
Subject: Re: [PATCH 2/7] ARM: s3c64xx: Include header to fix -Wmissing-prototypes

2020年7月29日(水) 18:11 Krzysztof Kozlowski <krzk@...nel.org>:
>
> Include the spi-s3c64xx.h header to fix W=1 build warning:
>
>     arch/arm/mach-s3c64xx/setup-spi.c:11:5: warning:
>         no previous prototype for 's3c64xx_spi0_cfg_gpio' [-Wmissing-prototypes]
>        11 | int s3c64xx_spi0_cfg_gpio(void)
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  arch/arm/mach-s3c64xx/setup-spi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c64xx/setup-spi.c b/arch/arm/mach-s3c64xx/setup-spi.c
> index 39dfae1f46e7..03c9d296bb0f 100644
> --- a/arch/arm/mach-s3c64xx/setup-spi.c
> +++ b/arch/arm/mach-s3c64xx/setup-spi.c
> @@ -4,6 +4,7 @@
>  //             http://www.samsung.com/
>
>  #include <linux/gpio.h>
> +#include <linux/platform_data/spi-s3c64xx.h>
>  #include <plat/gpio-cfg.h>
>  #include <mach/gpio-samsung.h>
>
> --
> 2.17.1
>

Reviewed-by: Tomasz Figa <tomasz.figa@...il.com>

Best regards,
Tomasz