linux-kernel - Re: [PATCH v2 1/2] usb: xhci: define IDs for various ASMedia host controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Jul 2020 21:08:00 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Forest Crossman <cyrozap@...il.com>, linux-usb@...r.kernel.org
Cc:     mathias.nyman@...el.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] usb: xhci: define IDs for various ASMedia host
 controllers

Hello!

On 7/28/20 7:24 AM, Forest Crossman wrote:

> Not all ASMedia host controllers have a device ID that matches its part
> number. #define some of these IDs to make it clearer at a glance which
> chips require what quirks.
> 
> Signed-off-by: Forest Crossman <cyrozap@...il.com>
> ---
>  drivers/usb/host/xhci-pci.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 9234c82e70e4..baa5af88ca67 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
[...]
> @@ -260,13 +262,13 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  		xhci->quirks |= XHCI_LPM_SUPPORT;
>  
>  	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
> -			pdev->device == 0x1042)
> +		pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI)

   You shouldn't have un-indented it, blends with the branch below.
   The 80-column line length limit is history now. :-)

>  		xhci->quirks |= XHCI_BROKEN_STREAMS;
>  	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
> -			pdev->device == 0x1142)
> +		pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI)
>  		xhci->quirks |= XHCI_TRUST_TX_LENGTH;
>  	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
> -			pdev->device == 0x2142)
> +		pdev->device == PCI_DEVICE_ID_ASMEDIA_2142_XHCI)
>  		xhci->quirks |= XHCI_NO_64BIT_SUPPORT;
>  
>  	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&

MBR, Sergei