linux-kernel - Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function ‘get_random_bytes’; did you mean ‘get_random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Jul 2020 22:04:32 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
CC:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        "Theodore Ts'o" <tytso@....edu>, Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Mark Brown <broonie@...nel.org>,
        Richard Henderson <richard.henderson@...aro.org>,
        open list <linux-kernel@...r.kernel.org>,
        <lkft-triage@...ts.linaro.org>, Emese Revfy <re.emese@...il.com>,
        <hsinyi@...omium.org>, Will Deacon <will@...nel.org>,
        Willy Tarreau <w@....eu>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function ‘get_random_bytes’; did you mean ‘get_random_once’?



On 30/07/2020 21:56, Linus Torvalds wrote:
> On Thu, Jul 30, 2020 at 11:47 AM Grygorii Strashko
> <grygorii.strashko@...com> wrote:
>>
>>
>> I'd like to note that below set of patches:
>> 1c9df907da83 random: fix circular include dependency on arm64 after addition of percpu.h
>> 83bdc7275e62 random32: remove net_rand_state from the latent entropy gcc plugin
>> f227e3ec3b5c random32: update the net random state on interrupt and activity
>>
>> also break ARM build for the case:
>> #if defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6)
> 
> Lovely.
> 
> I think I'll have to revert 1c9df907da83 after all, and  use Marc
> Zyngier's patch to just remove that troublesome <asm/pointer_auth.h>
> include in arm64 instead.
> 
> This turned out to be much messier than it should have been.

FYI. Below diff seems fixes build:

diff --git a/arch/arm/include/asm/percpu.h b/arch/arm/include/asm/percpu.h
index f44f448537f2..1a3eedbac4a2 100644
--- a/arch/arm/include/asm/percpu.h
+++ b/arch/arm/include/asm/percpu.h
@@ -5,6 +5,8 @@
  #ifndef _ASM_ARM_PERCPU_H_
  #define _ASM_ARM_PERCPU_H_
  
+#include <asm/thread_info.h>
+
  /*
   * Same as asm-generic/percpu.h, except that we store the per cpu offset
   * in the TPIDRPRW. TPIDRPRW only exists on V6K and V7


-- 
Best regards,
grygorii