linux-kernel - Re: [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200730231813.GF3145664@google.com>
Date:   Thu, 30 Jul 2020 16:18:13 -0700
From:   Prashant Malani <pmalani@...omium.org>
To:     "Shaikh, Azhar" <azhar.shaikh@...el.com>
Cc:     "bleung@...omium.org" <bleung@...omium.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "groeck@...omium.org" <groeck@...omium.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "Patel, Utkarsh H" <utkarsh.h.patel@...el.com>,
        "Bowman, Casey G" <casey.g.bowman@...el.com>,
        "Mani, Rajmohan" <rajmohan.mani@...el.com>
Subject: Re: [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum values
 to usb_role_switch_set_role()

On Thu, Jul 30, 2020 at 11:14:39PM +0000, Shaikh, Azhar wrote:
> 
> 
> > -----Original Message-----
> > From: Prashant Malani <pmalani@...omium.org>
> > Sent: Thursday, July 30, 2020 4:05 PM
> > To: Shaikh, Azhar <azhar.shaikh@...el.com>
> > Cc: bleung@...omium.org; enric.balletbo@...labora.com;
> > groeck@...omium.org; linux-kernel@...r.kernel.org;
> > heikki.krogerus@...ux.intel.com; Patel, Utkarsh H
> > <utkarsh.h.patel@...el.com>; Bowman, Casey G
> > <casey.g.bowman@...el.com>; Mani, Rajmohan
> > <rajmohan.mani@...el.com>
> > Subject: Re: [PATCH v2 1/2] platform/chrome: cros_ec_typec: Send enum
> > values to usb_role_switch_set_role()
> > 
> > 
> > On Thu, Jul 30, 2020 at 11:02:28PM +0000, Shaikh, Azhar wrote:
> > > Hi Prashant,
> > >
> > > >
> > > > Please add the list of changes in each version after the "---" line.
> > >
> > > I have added those in the cover letter.
> > > >
> > It is good practice to add these to the individual change too, so that the
> > reader doesn't have to go back to the cover letter to determine what has
> > changed in each patch.
> 
> So are you suggesting to move it from cover letter to individual patches?
> But then isn't the same thing what cover letter is for?

No, I'm suggesting you keep it both places. Each patch should have a
change log documenting what has changed in the various versions.