linux-kernel - Re: bpfilter logging write errors in dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200730155527.GB1829@supreme>
Date:   Thu, 30 Jul 2020 12:55:27 -0300
From:   Rodrigo Madera <rodrigo.madera@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     christian.brauner@...ntu.com, linux-kernel@...r.kernel.org
Subject: Re: bpfilter logging write errors in dmesg

On Thu, Jul 30, 2020 at 08:06:54AM +0200, Christoph Hellwig wrote:
> Ho Rodrigo,
> 
> please try this patch:
> 
> diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c
> index 1905e01c3aa9a7..4494ea6056cdb8 100644
> --- a/net/bpfilter/bpfilter_kern.c
> +++ b/net/bpfilter/bpfilter_kern.c
> @@ -39,7 +39,7 @@ static int __bpfilter_process_sockopt(struct sock *sk, int optname,
>  {
>  	struct mbox_request req;
>  	struct mbox_reply reply;
> -	loff_t pos;
> +	loff_t pos = 0;
>  	ssize_t n;
>  	int ret = -EFAULT;
>  

Christoph,

This killed the issue!

Can't believe I missed it... The pos numbers were a dead giveaway!

Let me know if you wish to do any other tests on my end.

Best regards,
Madera