linux-kernel - Re: [PATCH v3 15/15] iio: sx9310: Use irq trigger flags from firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Jul 2020 22:46:55 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Daniel Campello <campello@...omium.org>
Cc:     LKML <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v3 15/15] iio: sx9310: Use irq trigger flags from firmware

On Fri, Jul 31, 2020 at 7:49 PM Daniel Campello <campello@...omium.org> wrote:
>
> From: Stephen Boyd <swboyd@...omium.org>
>
> We shouldn't need to set default irq trigger flags here as the firmware
> should have properly indicated the trigger type, i.e. level low, in the
> DT or ACPI tables.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> Signed-off-by: Daniel Campello <campello@...omium.org>
> ---
>
> Changes in v3:
>  - Added irq trigger flags commit to the series.
>
> Changes in v2: None
>
>  drivers/iio/proximity/sx9310.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c
> index a20cd6a4dad729..c41fa7f6558e3f 100644
> --- a/drivers/iio/proximity/sx9310.c
> +++ b/drivers/iio/proximity/sx9310.c
> @@ -951,7 +951,7 @@ static int sx9310_probe(struct i2c_client *client)
>                 ret = devm_request_threaded_irq(dev, client->irq,
>                                                 sx9310_irq_handler,
>                                                 sx9310_irq_thread_handler,
> -                                               IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> +                                               IRQF_ONESHOT,
>                                                 "sx9310_event", indio_dev);
>                 if (ret)
>                         return ret;
> --
> 2.28.0.163.g6104cc2f0b6-goog
>


-- 
With Best Regards,
Andy Shevchenko