[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200731165023.11eb5d5b@oasis.local.home>
Date: Fri, 31 Jul 2020 16:50:23 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: peterz@...radead.org
Cc: Dongdong Yang <contribute.kernel@...il.com>,
gregkh@...uxfoundation.org, rjw@...ysocki.net,
viresh.kumar@...aro.org, mingo@...hat.com, juri.lelli@...hat.com,
vincent.guittot@...aro.org, dietmar.eggemann@....com,
bsegall@...gle.com, mgorman@...e.de, linux-kernel@...r.kernel.org,
devel@...verdev.osuosl.org, linux-pm@...r.kernel.org,
yangdongdong@...omi.com, tanggeliang@...omi.com, taojun@...omi.com,
huangqiwu@...omi.com, rocking@...ux.alibaba.com,
fengwei@...omi.com, zhangguoquan@...omi.com, gulinghua@...omi.com,
duhui@...omi.com
Subject: Re: [PATCH] sched: Provide USF for the portable equipment.
On Fri, 31 Jul 2020 20:15:38 +0200
peterz@...radead.org wrote:
> On Thu, Jul 30, 2020 at 09:35:43PM +0800, Dongdong Yang wrote:
> > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> > index 7fbaee2..7bc3429 100644
> > --- a/kernel/sched/cpufreq_schedutil.c
> > +++ b/kernel/sched/cpufreq_schedutil.c
> > @@ -289,12 +289,21 @@ unsigned long schedutil_cpu_util(int cpu, unsigned long util_cfs,
> > return min(max, util);
> > }
> >
> > +#ifdef CONFIG_SCHED_USF
> > +void (*adjust_task_pred_demand)(int cpuid, unsigned long *util,
> > + struct rq *rq) = NULL;
> > +EXPORT_SYMBOL(adjust_task_pred_demand);
> > +#endif
> > +
> > static unsigned long sugov_get_util(struct sugov_cpu *sg_cpu)
> > {
> > struct rq *rq = cpu_rq(sg_cpu->cpu);
> > unsigned long util = cpu_util_cfs(rq);
> > unsigned long max = arch_scale_cpu_capacity(sg_cpu->cpu);
> > -
> > +#ifdef CONFIG_SCHED_USF
> > + if (adjust_task_pred_demand)
> > + adjust_task_pred_demand(sg_cpu->cpu, &util, rq);
> > +#endif
> > sg_cpu->max = max;
> > sg_cpu->bw_dl = cpu_bw_dl(rq);
>
> NAK
Peter,
It's more informative if you include rational with a NAK.
-- Steve
Powered by blists - more mailing lists