linux-kernel - Re: [PATCH v2] dt-bindings: regulator: Convert sy8824x to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200731211629.GA801219@bogus>
Date:   Fri, 31 Jul 2020 15:16:29 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jisheng Zhang <jszhang3@...l.ustc.edu.cn>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: regulator: Convert sy8824x to json-schema

On Wed, Jul 29, 2020 at 12:53:20PM +0800, Jisheng Zhang wrote:
> From: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> 
> Convert the sy8824x binding to DT schema format using json-schema.
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> ---
> 
> Since v1
>   -It seems there's something wrong with my last email, so send out a v2 with
>    another email account
> 
>  .../bindings/regulator/silergy,sy8824x.yaml   | 40 +++++++++++++++++++
>  .../devicetree/bindings/regulator/sy8824x.txt | 24 -----------
>  2 files changed, 40 insertions(+), 24 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/regulator/silergy,sy8824x.yaml
>  delete mode 100644 Documentation/devicetree/bindings/regulator/sy8824x.txt
> 
> diff --git a/Documentation/devicetree/bindings/regulator/silergy,sy8824x.yaml b/Documentation/devicetree/bindings/regulator/silergy,sy8824x.yaml
> new file mode 100644
> index 000000000000..62a476c94111
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/silergy,sy8824x.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/silergy,sy8824x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: silergy sy8824c,sy8824e,sy20276 and sy20278 PMIC
> +
> +maintainers:
> +  - Jisheng Zhang <jszhang@...nel.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - silergy,sy8824c
> +      - silergy,sy8824e
> +      - silergy,sy20276
> +      - silergy,sy20278
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg

Needs a $ref to regulator.yaml and then:

unevaluatedProperties: false

> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        regulator@60 {
> +          compatible = "silergy,sy8824c";
> +          regulator-min-microvolt = <800000>;
> +          regulator-max-microvolt = <1150000>;
> +          reg = <0x60>;
> +        };
> +    };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/regulator/sy8824x.txt b/Documentation/devicetree/bindings/regulator/sy8824x.txt
> deleted file mode 100644
> index c5e95850c427..000000000000
> --- a/Documentation/devicetree/bindings/regulator/sy8824x.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -SY8824C/SY8824E/SY20276 Voltage regulator
> -
> -Required properties:
> -- compatible: Must be one of the following.
> -	"silergy,sy8824c"
> -	"silergy,sy8824e"
> -	"silergy,sy20276"
> -	"silergy,sy20278"
> -- reg: I2C slave address
> -
> -Any property defined as part of the core regulator binding, defined in
> -./regulator.txt, can also be used.
> -
> -Example:
> -
> -	vcore: regulator@00 {
> -		compatible = "silergy,sy8824c";
> -		reg = <0x66>;
> -		regulator-name = "vcore";
> -		regulator-min-microvolt = <800000>;
> -		regulator-max-microvolt = <1150000>;
> -		regulator-boot-on;
> -		regulator-always-on;
> -	};
> -- 
> 2.28.0.rc0
> 
>