linux-kernel - Re: [PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200731213028.GA824739@bogus>
Date:   Fri, 31 Jul 2020 15:30:28 -0600
From:   Rob Herring <robh@...nel.org>
To:     Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
Cc:     alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, ludovic.desroches@...rochip.com
Subject: Re: [PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip
 S/PDIF TX Controller

On Wed, Jul 29, 2020 at 01:19:21PM +0300, Codrin Ciubotariu wrote:
> This patch adds DT bindings for the new Microchip S/PDIF TX Controller
> embedded inside sama7g5 SoCs.
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> ---
> 
> Changes in v2:
>  - replaced https with http
>  - reworked example, included bindings;
> 
>  .../bindings/sound/mchp,spdiftx.yaml          | 80 +++++++++++++++++++
>  1 file changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> new file mode 100644
> index 000000000000..2b7c27391f0d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mchp,spdiftx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip S/PDIF Tx Controller Device Tree Bindings
> +
> +maintainers:
> +  - Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> +
> +description:
> +        The Microchip Sony/Philips Digital Interface Transmitter is a
> +        serial port compliant with the IEC-60958 standard.
> +
> +properties:
> +  "#sound-dai-cells":
> +    const: 0
> +
> +  compatible:
> +    oneOf:
> +      - const: microchip,sama7g5-spdiftx

No need for 'oneOf' when only 1 entry.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: Peripheral Bus Clock
> +      - description: Generic Clock
> +
> +  clock-names:
> +    items:
> +      - const: pclk
> +      - const: gclk
> +
> +  dmas:
> +    description: TX DMA Channel

How many? (maxItems: 1)

> +
> +  dma-names:
> +    const: tx
> +
> +  pinctrl-0: true
> +
> +  pinctrl-names:
> +    const: default

You can drop pinctrl props. They are always allowed.

> +
> +required:
> +  - "#sound-dai-cells"
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - dmas
> +  - dma-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/at91.h>
> +    #include <dt-bindings/dma/at91.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    spdiftx@...18000 {
> +        #sound-dai-cells = <0>;
> +        compatible = "microchip,sama7g5-spdiftx";
> +        reg = <0xe1618000 0x4000>;
> +        interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> +        dmas = <&dma0 AT91_XDMAC_DT_PERID(50)>;
> +        dma-names = "tx";
> +        clocks = <&pmc PMC_TYPE_PERIPHERAL 85>, <&pmc PMC_TYPE_GCK 85>;
> +        clock-names = "pclk", "gclk";
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&pinctrl_spdiftx_default>;
> +    };
> -- 
> 2.25.1
>