linux-kernel - Re: [PATCH][next] mlxsw: spectrum_cnt: Use flex_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200730.173935.1057438302921920842.davem@davemloft.net>
Date:   Thu, 30 Jul 2020 17:39:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gustavoars@...nel.org
Cc:     jiri@...lanox.com, idosch@...lanox.com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] mlxsw: spectrum_cnt: Use flex_array_size()
 helper in memcpy()

From: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Date: Wed, 29 Jul 2020 17:58:03 -0500

> Make use of the flex_array_size() helper to calculate the size of a
> flexible array member within an enclosing structure.
> 
> This helper offers defense-in-depth against potential integer
> overflows, while at the same time makes it explicitly clear that
> we are dealing witha flexible array member.
> 
> Also, remove unnecessary pointer identifier sub_pool.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Applied.