linux-kernel - Re: [PATCH] scsi: libcxgbi: use kvzalloc instead of opencoded kzalloc/vzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8638183f559c0f8f8d377bd0a6c91903b2c588df.camel@perches.com>
Date:   Fri, 31 Jul 2020 15:24:33 -0700
From:   Joe Perches <joe@...ches.com>
To:     Denis Efremov <efremov@...ux.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: libcxgbi: use kvzalloc instead of opencoded
 kzalloc/vzalloc

On Sat, 2020-08-01 at 01:10 +0300, Denis Efremov wrote:
> 
> On 8/1/20 12:58 AM, Joe Perches wrote:
> > On Sat, 2020-08-01 at 00:55 +0300, Denis Efremov wrote:
> > > Remove cxgbi_alloc_big_mem(), cxgbi_free_big_mem() functions
> > > and use kvzalloc/kvfree instead.
> > 
> > Sensible, thanks.
> > 
> > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> > []
> > > @@ -77,9 +77,9 @@ int cxgbi_device_portmap_create(struct cxgbi_device *cdev, unsigned int base,
> > >  {
> > >  	struct cxgbi_ports_map *pmap = &cdev->pmap;
> > >  
> > > -	pmap->port_csk = cxgbi_alloc_big_mem(max_conn *
> > > -					     sizeof(struct cxgbi_sock *),
> > > -					     GFP_KERNEL);
> > > +	pmap->port_csk = kvzalloc(array_size(max_conn,
> > > +					     sizeof(struct cxgbi_sock *)),
> > > +				  GFP_KERNEL);
> > 
> > missing __GFP_NOWARN
> > 
> 
> kvmalloc_node adds __GFP_NOWARN internally to kmalloc call
> https://elixir.bootlin.com/linux/v5.8-rc4/source/mm/util.c#L568

Only when there's a fallback, and the fallback does not.