lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 31 Jul 2020 07:41:46 +0200
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Ondrej Jirman <megous@...ous.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>, Luca Weiss <luca@...tu.xyz>,
        Tomas Novotny <tomas@...otny.cz>, linux-input@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 3/4] ARM: dts: sun8i-a83t-tbs-a711: Add support for
 the vibrator motor

Hi Ondrej,

On 20-07-30 15:24, Ondrej Jirman wrote:
> The board has a vibrator motor. Hook it to the input subsystem.
> 
> According to the PMIC specification, LDO needs to be enabled (value 0b11)
> to achieve the specified max driving current of 150mA. We can't drive
> the motor with just GPIO mode.
> 
> In GPIO mode the chip is probably just using the regular CMOS logic
> output circuitry (typically limited to around 20-35mA, but not specified
> in this datasheet).
> 
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> ---
>  arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> index bfc9bb277a49..a278a1e33930 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> @@ -99,6 +99,11 @@ panel_input: endpoint {
>  		};
>  	};
>  
> +	vibrator {
> +		compatible = "gpio-vibrator";
> +		vcc-supply = <&reg_ldo_io1>;
> +	};

Please keep the alphabetical order. I also would merge patch 3 and 4
into one since they are realted changes.

Regards,
  Marco

> +
>  	reg_gps: reg-gps {
>  		compatible = "regulator-fixed";
>  		regulator-name = "gps";

Powered by blists - more mailing lists