linux-kernel - Re: [PATCH v2 1/4] fpga: dfl: change data type of feature id to u16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200731074837.GE1781@yilunxu-OptiPlex-7050>
Date:   Fri, 31 Jul 2020 15:48:37 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Tom Rix <trix@...hat.com>
Cc:     mdf@...nel.org, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, lgoncalv@...hat.com
Subject: Re: [PATCH v2 1/4] fpga: dfl: change data type of feature id to u16

On Sat, Jul 25, 2020 at 06:29:53AM -0700, Tom Rix wrote:
> It would be good if the variable or element for the feature id had a consistent name.
> 
> 
> > @@ -197,7 +197,7 @@ int dfl_fpga_check_port_id(struct platform_device *pdev, void *pport_id);
> >   * @id: unique dfl private feature id.
> >   */
> >  struct dfl_feature_id {
> > -	u64 id;
> > +	u16 id;
> >  };
> 
> Is this structure needed ?
> 
> Here is how it could be changed to 
> 
> struct dfl_feature_driver {
> 
> -    const dfl_feature_id *
> 
> +    const u16 *id_table;

This structure is to represent an id type, which is used to match
fme/port owned features. It could be extended if some feature drivers
needs driver_data.

Actually I see some example of device_ids with similar structure, like:

  struct mips_cdmm_device_id {
  	__u8	type;
  };

  struct tee_client_device_id {
	uuid_t uuid;
  };


Thanks,
Yilun.

> 
> ...
> 
> Tom
> 
> 
> >  
> >  /**
> > @@ -240,7 +240,7 @@ struct dfl_feature_irq_ctx {
> >   */
> >  struct dfl_feature {
> >  	struct platform_device *dev;
> > -	u64 id;
> > +	u16 id;
> >  	int resource_index;
> >  	void __iomem *ioaddr;
> >  	struct dfl_feature_irq_ctx *irq_ctx;
> > @@ -371,7 +371,7 @@ struct platform_device *dfl_fpga_inode_to_feature_dev(struct inode *inode)
> >  	   (feature) < (pdata)->features + (pdata)->num; (feature)++)
> >  
> >  static inline
> > -struct dfl_feature *dfl_get_feature_by_id(struct device *dev, u64 id)
> > +struct dfl_feature *dfl_get_feature_by_id(struct device *dev, u16 id)
> >  {
> >  	struct dfl_feature_platform_data *pdata = dev_get_platdata(dev);
> >  	struct dfl_feature *feature;
> > @@ -384,7 +384,7 @@ struct dfl_feature *dfl_get_feature_by_id(struct device *dev, u64 id)
> >  }
> >  
> >  static inline
> > -void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u64 id)
> > +void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
> >  {
> >  	struct dfl_feature *feature = dfl_get_feature_by_id(dev, id);
> >  
> > @@ -395,7 +395,7 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u64 id)
> >  	return NULL;
> >  }
> >  
> > -static inline bool is_dfl_feature_present(struct device *dev, u64 id)
> > +static inline bool is_dfl_feature_present(struct device *dev, u16 id)
> >  {
> >  	return !!dfl_get_feature_ioaddr_by_id(dev, id);
> >  }