linux-kernel - Re: [PATCH v2 10/11] media: exynos4-is: Handle duplicate calls to vidioc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e99235a5-0d8a-9948-596e-beff3da4b12e@samsung.com>
Date:   Fri, 31 Jul 2020 11:54:41 +0200
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Jonathan Bakker <xc-racer2@...e.ca>, linux-media@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kyungmin.park@...sung.com, mchehab@...nel.org, kgene@...nel.org,
        krzk@...nel.org, devicetree@...r.kernel.org, robh+dt@...nel.org
Subject: Re: [PATCH v2 10/11] media: exynos4-is: Handle duplicate calls to
 vidioc_streamoff

On 31.07.2020 01:01, Jonathan Bakker wrote:
> vidioc_streamoff can be called multiple times from userspace, but we
> should only call media_pipeline_stop when we're actually setup.
> 
> This became more noticeable after commit 2a2599c66368 ("[media] media:
> entity: Catch unbalanced media_pipeline_stop calls") was merged as it
> added a WARN for unbalanced calls to media_pipeline_stop.
> 
> Signed-off-by: Jonathan Bakker <xc-racer2@...e.ca>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@...sung.com>