linux-kernel - Re: [PATCH] arm64: dts: mt8173: elm: Fix nor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8aedcc7e-fea5-367c-e3a8-8a013cf629c1@collabora.com>
Date:   Fri, 31 Jul 2020 13:20:56 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Hsin-Yi Wang <hsinyi@...omium.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property

Hi Hsin-Yi,

Thank you for your patch.

On 27/7/20 9:41, Hsin-Yi Wang wrote:
> bus-width and non-removable is not used by the driver.
> max-frequency should be spi-max-frequency for flash node.
> 
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Reported-by: Nicolas Boichat <drinkcat@...omium.org>
> Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

> ---
>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index a5a12b2599a4..01522dd10603 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -431,12 +431,11 @@ &nor_flash {
>  	status = "okay";
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&nor_gpio1_pins>;
> -	bus-width = <8>;
> -	max-frequency = <50000000>;
> -	non-removable;
> +
>  	flash@0 {
>  		compatible = "jedec,spi-nor";
>  		reg = <0>;
> +		spi-max-frequency = <50000000>;
>  	};
>  };
>  
>