linux-kernel - Re: [PATCH] i2c: designware: Add device HID for Hygon I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200731134950.GB1679@kunai>
Date:   Fri, 31 Jul 2020 15:49:50 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Pu Wen <puwen@...on.cn>
Cc:     rjw@...ysocki.net, lenb@...nel.org, jarkko.nikula@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, mika.westerberg@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: designware: Add device HID for Hygon I2C controller

On Fri, Jul 31, 2020 at 04:48:45PM +0800, Pu Wen wrote:
> Add device HID HYGO0010 to match the Hygon ACPI Vendor ID (HYGO) that
> was registered in http://www.uefi.org/acpi_id_list, and the I2C
> controller on Hygon paltform will use the HID.
> 
> Signed-off-by: Pu Wen <puwen@...on.cn>

I can take this via I2C, but I'd need an ack from Rafael or Len.

Or it can go via ACPI, fine with me

Acked-by: Wolfram Sang <wsa@...nel.org>

> ---
>  drivers/acpi/acpi_apd.c                     | 1 +
>  drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index ba2612e9a0eb..f24f6d3f1fa5 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -240,6 +240,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
>  	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
>  	{ "AMD0030", },
>  	{ "AMD0040", APD_ADDR(st_misc_desc)},
> +	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
>  #endif
>  #ifdef CONFIG_ARM64
>  	{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index a71bc58fc03c..0dfeb2d11603 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -55,6 +55,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>  	{ "HISI02A1", 0 },
>  	{ "HISI02A2", 0 },
>  	{ "HISI02A3", 0 },
> +	{ "HYGO0010", ACCESS_INTR_MASK },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> -- 
> 2.23.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)