linux-kernel - Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e30e2df7bec0fedf1a29f7825fbb4c12593eac9.camel@perches.com>
Date:   Fri, 31 Jul 2020 09:35:42 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+

On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> Increase columns highlighting to 100+ once the 80-column warning has
> been deprecated in the Linux kernel[1].
> 
> [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
>  plugin/linuxsty.vim | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> index 6f7e331..c42ce72 100644
> --- a/plugin/linuxsty.vim
> +++ b/plugin/linuxsty.vim
> @@ -62,7 +62,7 @@ function s:LinuxFormatting()
>      setlocal tabstop=8
>      setlocal shiftwidth=8
>      setlocal softtabstop=8
> -    setlocal textwidth=80
> +    setlocal textwidth=100

This is not a good change.
80 columns is still _preferred_.

It's just checkpatch will not emit a warning
for lines longer than 80 columns but will
for lines longer than 100 columns.

checkpatch will also not emit a warning on
file checking at all.


>      setlocal noexpandtab
>  
>      setlocal cindent
> @@ -80,7 +80,7 @@ function s:LinuxHighlighting()
>      highlight default link LinuxError ErrorMsg
>  
>      syn match LinuxError / \+\ze\t/     " spaces before tab
> -    syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more
> +    syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more
>  
>      " Highlight trailing whitespace, unless we're in insert mode and the
>      " cursor's placed right after the whitespace. This prevents us from having