linux-kernel - Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2b0b4a44901674d46de9f949227f35afd21062b.camel@perches.com>
Date:   Fri, 31 Jul 2020 10:17:01 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+

On Fri, 2020-07-31 at 12:07 -0500, Gustavo A. R. Silva wrote:
> On Fri, Jul 31, 2020 at 09:35:42AM -0700, Joe Perches wrote:
> > On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> > > Increase columns highlighting to 100+ once the 80-column warning has
> > > been deprecated in the Linux kernel[1].
> > > 
> > > [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> > > 
> > > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> > > ---
> > >  plugin/linuxsty.vim | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> > > index 6f7e331..c42ce72 100644
> > > --- a/plugin/linuxsty.vim
> > > +++ b/plugin/linuxsty.vim
> > > @@ -62,7 +62,7 @@ function s:LinuxFormatting()
> > >      setlocal tabstop=8
> > >      setlocal shiftwidth=8
> > >      setlocal softtabstop=8
> > > -    setlocal textwidth=80
> > > +    setlocal textwidth=100
> > 
> > This is not a good change.
> > 80 columns is still _preferred_.
> > 
> 
> Now that you mention that, I have mixed feelings about this.
> Let's see if we can get more opinions...

I am not a vim user, but maybe remove this line
altogether and add something like

	setlocal colorcolumn=80,100

and let people make their own wrapping decisions.