linux-kernel - Re: [PATCH -next] sched/uclamp: kill unnecessary mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200730225756.11283799@oasis.local.home>
Date:   Thu, 30 Jul 2020 22:57:56 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Ben Segall <bsegall@...gle.com>,
        "Mel Gorman" <mgorman@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] sched/uclamp: kill unnecessary mutex_init()

On Sat, 25 Jul 2020 16:56:29 +0800
Qinglang Miao <miaoqinglang@...wei.com> wrote:

> The mutex uclamp_mutex is initialized statically. It is
> unnecessary to initialize by mutex_init().
> 

Seems reasonable.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  kernel/sched/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 29d557c1f..9a8b7ed3a 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1331,8 +1331,6 @@ static void __init init_uclamp(void)
>  	enum uclamp_id clamp_id;
>  	int cpu;
>  
> -	mutex_init(&uclamp_mutex);
> -
>  	for_each_possible_cpu(cpu)
>  		init_uclamp_rq(cpu_rq(cpu));
>