linux-kernel - Re: [PATCH] usb: gadget: s3c: Remove unused 'udc' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200731183854.GA2279514@ubuntu-n2-xlarge-x86>
Date:   Fri, 31 Jul 2020 11:38:54 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: s3c: Remove unused 'udc' variable

On Fri, Jul 31, 2020 at 09:41:22AM +0200, Krzysztof Kozlowski wrote:
> Remove unused 'udc' variable to fix compile warnings:
> 
>     drivers/usb/gadget/udc/s3c2410_udc.c: In function 's3c2410_udc_dequeue':
>     drivers/usb/gadget/udc/s3c2410_udc.c:1268:22: warning: variable 'udc' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Weird, looks like it has been unused since the introduction of the
driver.

Reviewed-by: Nathan Chancellor <natechancellor@...il.com>

> ---
>  drivers/usb/gadget/udc/s3c2410_udc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
> index bc2e8eb737c3..e875a0b967c0 100644
> --- a/drivers/usb/gadget/udc/s3c2410_udc.c
> +++ b/drivers/usb/gadget/udc/s3c2410_udc.c
> @@ -1270,7 +1270,6 @@ static int s3c2410_udc_queue(struct usb_ep *_ep, struct usb_request *_req,
>  static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)
>  {
>  	struct s3c2410_ep	*ep = to_s3c2410_ep(_ep);
> -	struct s3c2410_udc	*udc;
>  	int			retval = -EINVAL;
>  	unsigned long		flags;
>  	struct s3c2410_request	*req = NULL;
> @@ -1283,8 +1282,6 @@ static int s3c2410_udc_dequeue(struct usb_ep *_ep, struct usb_request *_req)
>  	if (!_ep || !_req)
>  		return retval;
>  
> -	udc = to_s3c2410_udc(ep->gadget);
> -
>  	local_irq_save(flags);
>  
>  	list_for_each_entry(req, &ep->queue, queue) {
> -- 
> 2.17.1
>