lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 1 Aug 2020 17:30:23 +0800 From: linmiaohe <linmiaohe@...wei.com> To: <davem@...emloft.net>, <kuba@...nel.org>, <fw@...len.de>, <pshelar@....org>, <martin.varghese@...ia.com>, <pabeni@...hat.com>, <edumazet@...gle.com>, <dcaratti@...hat.com>, <steffen.klassert@...unet.com>, <shmulik@...anetworks.com>, <kyk.segfault@...il.com> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linmiaohe@...wei.com> Subject: [PATCH] net: Use __skb_pagelen() directly in skb_cow_data() From: Miaohe Lin <linmiaohe@...wei.com> In fact, skb_pagelen() - skb_headlen() is equal to __skb_pagelen(), use it directly to avoid unnecessary skb_headlen() call. Also fix the CHECK note of checkpatch.pl: Comparison to NULL could be written "!__pskb_pull_tail" Signed-off-by: Miaohe Lin <linmiaohe@...wei.com> --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index b8afefe6f6b6..3219c26ddfae 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -4413,7 +4413,7 @@ int skb_cow_data(struct sk_buff *skb, int tailbits, struct sk_buff **trailer) * at the moment even if they are anonymous). */ if ((skb_cloned(skb) || skb_shinfo(skb)->nr_frags) && - __pskb_pull_tail(skb, skb_pagelen(skb)-skb_headlen(skb)) == NULL) + !__pskb_pull_tail(skb, __skb_pagelen(skb))) return -ENOMEM; /* Easy case. Most of packets will go this way. */ -- 2.19.1
Powered by blists - more mailing lists