linux-kernel - Re: [PATCH 1/2] Bluetooth: hci_h5: Stop erroneously setting HCI_UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <789a7d61-bdc0-19a2-d4e0-03b2f89bb516@sholland.org>
Date:   Sat, 1 Aug 2020 11:24:46 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: hci_h5: Stop erroneously setting
 HCI_UART_REGISTERED

On 8/1/20 10:43 AM, Samuel Holland wrote:
> This code attempts to set the HCI_UART_RESET_ON_INIT flag. However,
> it sets the bit in the wrong flag word: HCI_UART_RESET_ON_INIT goes in
> hu->hdev_flags, not hu->flags. So it is actually setting
> HCI_UART_REGISTERED, which is bit 1 in hu->flags.
> 
> Since commit cba736465e5c ("Bluetooth: hci_serdev: Remove setting of
> HCI_QUIRK_RESET_ON_CLOSE."), this flag is ignored for hci_serdev users,
> so instead of fixing which flag is set, let's remove the flag entirely.
> 
> Cc: stable@...r.kernel.org
> Fixes: ce945552fde4 ("Bluetooth: hci_h5: Add support for serdev enumerated devices")
> Signed-off-by: Samuel Holland <samuel@...lland.org>
> ---
>  drivers/bluetooth/hci_h5.c | 2 --
>  1 file changed, 2 deletions(-)

Sorry, I didn't see the other patches that were just added to -next.
I'll rebase my additional changes on top of them and resend.

Regards,
Samuel