lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 1 Aug 2020 16:26:07 -0400 From: Paul Moore <paul@...l-moore.com> To: Joe Perches <joe@...ches.com>, Jules Irenge <jbi.octave@...il.com> Cc: linux-kernel@...r.kernel.org, Eric Paris <eparis@...hat.com>, "moderated list:AUDIT SUBSYSTEM" <linux-audit@...hat.com> Subject: Re: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid On Sat, Aug 1, 2020 at 2:55 PM Joe Perches <joe@...ches.com> wrote: > On Sat, 2020-08-01 at 19:46 +0100, Jules Irenge wrote: > > Checkpatch tool reports an error at variable audit_sig_sid declaration > [] > > diff --git a/kernel/audit.c b/kernel/audit.c > [] > > @@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME; > > /* The identity of the user shutting down the audit system. */ > > kuid_t audit_sig_uid = INVALID_UID; > > pid_t audit_sig_pid = -1; > > -u32 audit_sig_sid = 0; > > +u32 audit_sig_sid; > > All of these are unused outside of audit.c and might as > well be static and removed from the .h file. There's plenty of time before the merge window closes, doing this would definitely make this patch much more useful than the typical checkpatch noise. -- paul moore www.paul-moore.com
Powered by blists - more mailing lists