linux-kernel - Re: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200802152951.3F2C4C433C6@smtp.codeaurora.org>
Date:   Sun,  2 Aug 2020 15:29:51 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Wang Yufen <wangyufen@...wei.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <brcm80211-dev-list@...ress.com>, <linux-wireless@...r.kernel.org>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <franky.lin@...adcom.com>, <wright.feng@...ress.com>,
        Wang Yufen <wangyufen@...wei.com>
Subject: Re: [PATCH net-next] brcm80211: fix possible memleak in
 brcmf_proto_msgbuf_attach

Wang Yufen <wangyufen@...wei.com> wrote:

> When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
> we should destroy the workqueue.
> 
> Fixes: 05491d2ccf20 ("brcm80211: move under broadcom vendor directory")

Moving the driver to another directory cannot have caused this bug, so I'm
removing the fixes tag. Please check your commit logs, don't just blindly copy
what git-blame says.

-- 
https://patchwork.kernel.org/patch/11673291/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches