linux-kernel - sparse warnings in vop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200802005458-mutt-send-email-mst@kernel.org>
Date:   Sun, 2 Aug 2020 00:57:17 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     sudeep.dutt@...el.com
Cc:     ashutosh.dixit@...el.com, arnd@...db.de,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: sparse warnings in vop

Hi!
Building vop with make C=1 produces the following:

CHECK   drivers/misc/mic/vop/vop_main.c
drivers/misc/mic/vop/vop_main.c:551:58: warning: incorrect type in argument 1 (different address spaces)
drivers/misc/mic/vop/vop_main.c:551:58:    expected void const volatile [noderef] __iomem *addr
drivers/misc/mic/vop/vop_main.c:551:58:    got restricted __le64 *
drivers/misc/mic/vop/vop_main.c:560:49: warning: incorrect type in argument 1 (different address spaces)
drivers/misc/mic/vop/vop_main.c:560:49:    expected struct mic_device_ctrl *dc
drivers/misc/mic/vop/vop_main.c:560:49:    got struct mic_device_ctrl [noderef] __iomem *dc
drivers/misc/mic/vop/vop_main.c:579:49: warning: incorrect type in argument 1 (different address spaces)
drivers/misc/mic/vop/vop_main.c:579:49:    expected struct mic_device_ctrl *dc
drivers/misc/mic/vop/vop_main.c:579:49:    got struct mic_device_ctrl [noderef] __iomem *dc

Would be nice to fix to silence the noise, but I'm not 100% sure
what the right thing to do here is. Tag struct members with __iomem or
cast with __force on use?

-- 
MST