linux-kernel - Re: [PATCH 2/2] Bluetooth: hci_ldisc/hci_serdev: Cancel init work before unregistering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <33FE7F8B-3467-4BC6-B74C-CA7835A4E9CF@holtmann.org>
Date:   Sun, 2 Aug 2020 20:02:29 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
        Hans de Goede <hdegoede@...hat.com>,
        Bluetooth Kernel Mailing List 
        <linux-bluetooth@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: hci_ldisc/hci_serdev: Cancel init work
 before unregistering

Hi Samuel,

> If hci_uart_tty_close() or hci_uart_unregister_device() is called while
> hu->init_ready is scheduled, hci_register_dev() could be called after
> the hci_uart is torn down. Avoid this by ensuring the work is complete
> or canceled before checking the HCI_UART_REGISTERED flag.
> 
> Fixes: 9f2aee848fe6 ("Bluetooth: Add delayed init sequence support for UART controllers")
> Signed-off-by: Samuel Holland <samuel@...lland.org>
> ---
> drivers/bluetooth/hci_ldisc.c  | 1 +
> drivers/bluetooth/hci_serdev.c | 2 ++
> 2 files changed, 3 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel