linux-kernel - Re: [PATCH] splice: direct call for default_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7eb5960a-4e92-a479-127d-6a0462e43e55@gmail.com>
Date:   Sun, 2 Aug 2020 11:49:54 +0300
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] splice: direct call for default_file_splice*()

On 01/08/2020 20:41, Christoph Hellwig wrote:
> On Sat, Aug 01, 2020 at 01:12:22PM +0300, Pavel Begunkov wrote:
>> On 30/01/2020 19:54, Christoph Hellwig wrote:
>>> On Mon, Jan 20, 2020 at 11:49:46PM +0300, Pavel Begunkov wrote:
>>>> Indirect calls could be very expensive nowadays, so try to use direct calls
>>>> whenever possible.
>>
>> Hah, I'm surprised to find it as
>> 00c285d0d0fe4 ("fs: simplify do_splice_from").
>>
>> Christoph, even though this one is not a big deal, I'm finding the
>> practice of taking others patches and silently sending them as yours
>> own in general disgusting. Just for you to know.
> 
> Err, what makes you think I took your patch vs just not remembering
> and pointlessly doing the same cleanup again?  If I had rembered your
> patch I would have just added to the series with your credit as I've
> done for plenty other patches..

I have no intention of picking it to pieces or something, it doesn't
worth our time, and glad that's by accident, but you may guess how it
looks -- you commented on it, and after not being picked, the patch
reappears slightly rebranded.

-- 
Pavel Begunkov