lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Aug 2020 19:15:28 +0800 From: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> To: njavali@...vell.com, jejb@...ux.ibm.com, martin.petersen@...cle.com, himanshu.madhani@...ium.com, quinn.tran@...ium.com Cc: GR-QLogic-Storage-Upstream@...vell.com, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, tianjia.zhang@...baba.com Subject: [PATCH] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg() In the case of a failed retry, a positive value EIO is returned here. I think this is a typo error. It is necessary to return an error value. Fixes: 0691094ff3f2c ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion") Cc: Quinn Tran <quinn.tran@...ium.com> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index c2c0e6049da4..f2bb841c2059 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -5668,7 +5668,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host *vha, /* found existing exchange */ qpair->retry_term_cnt++; if (qpair->retry_term_cnt >= 5) { - rc = EIO; + rc = -EIO; qpair->retry_term_cnt = 0; ql_log(ql_log_warn, vha, 0xffff, "Unable to send ABTS Respond. Dumping firmware.\n"); -- 2.26.2
Powered by blists - more mailing lists