linux-kernel - Re: [PATCH V9 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159648374959.1360974.3090613408656313501@swboyd.mtv.corp.google.com>
Date:   Mon, 03 Aug 2020 12:42:29 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Anson Huang <Anson.Huang@....com>, abel.vesa@....com,
        aisheng.dong@....com, arnd@...db.de, daniel.baluta@....com,
        festevam@...il.com, fugang.duan@....com, kernel@...gutronix.de,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, mturquette@...libre.com,
        peng.fan@....com, s.hauer@...gutronix.de, shawnguo@...nel.org,
        yuehaibing@...wei.com
Cc:     Linux-imx@....com
Subject: Re: [PATCH V9 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits

Quoting Anson Huang (2020-07-29 18:22:49)
> Use readl_relaxed() instead of __raw_readl(), and use BIT(x)
> instead of (1 << X) to fix below build warning reported by kernel
> test robot:
> 
> drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit
> value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
>      while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK))
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> Reported-by: kernel test robot <lkp@...el.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@...nel.org>