linux-kernel - Re: [PATCH] of: unittest: Use bigger address cells to catch parser regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+oQyQhAaB-jP8MxKp9jTEbr4c0oxPY5FiwmQRcnqJOdg@mail.gmail.com>
Date:   Mon, 3 Aug 2020 16:27:39 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     Frank Rowand <frowand.list@...il.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        Nathan Chancellor <natechancellor@...il.com>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: unittest: Use bigger address cells to catch parser regressions

On Mon, Aug 3, 2020 at 8:25 AM Nicolas Saenz Julienne
<nsaenzjulienne@...e.de> wrote:
>
> Getting address and size cells for dma-ranges/ranges parsing is tricky
> and shouldn't rely on the node's count_cells() method. The function
> starts looking for cells on the parent node, as its supposed to work
> with device nodes, which doesn't work when input with bus nodes, as
> generally done when parsing ranges.
>
> Add test to catch regressions on that specific quirk as developers will
> be tempted to edit it out in favor of the default method.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> ---
>  drivers/of/unittest-data/tests-address.dtsi | 10 +++++-----
>  drivers/of/unittest.c                       |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)

Applied, thanks.

Rob