linux-kernel - Re: [PATCH] net: vmxnet3: avoid accessing the data mapped to streaming DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200803.155949.39743839019093809.davem@davemloft.net>
Date:   Mon, 03 Aug 2020 15:59:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baijiaju@...nghua.edu.cn
Cc:     doshir@...are.com, pv-drivers@...are.com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: vmxnet3: avoid accessing the data mapped to
 streaming DMA

From: Jia-Ju Bai <baijiaju@...nghua.edu.cn>
Date: Sun,  2 Aug 2020 21:11:07 +0800

> In vmxnet3_probe_device(), "adapter" is mapped to streaming DMA:
>   adapter->adapter_pa = dma_map_single(..., adapter, ...);
> 
> Then "adapter" is accessed at many places in this function.
> 
> Theses accesses may cause data inconsistency between CPU cache and 
> hardware.
> 
> To fix this problem, dma_map_single() is called after these accesses.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju@...nghua.edu.cn>

'adapter' is accessed everywhere, in the entire driver, not just here
in the probe function.