linux-kernel - Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200803084128.4ogaewayotcubff5@distanz.ch>
Date:   Mon, 3 Aug 2020 10:41:28 +0200
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
Cc:     ast@...nel.org, daniel@...earbox.net, kafai@...com,
        songliubraving@...com, yhs@...com, andriin@...com,
        john.fastabend@...il.com, kpsingh@...omium.org,
        quentin@...valent.com, kuba@...nel.org, toke@...hat.com,
        jolsa@...nel.org, netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, tianjia.zhang@...baba.com
Subject: Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

On 2020-08-02 at 13:15:40 +0200, Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> wrote:
> In case of btf_id does not exist, a negative error code -ENOENT
> should be returned.
> 
> Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types")
> Cc: Andrii Nakryiko <andriin@...com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>

Reviewed-by: Tobias Klauser <tklauser@...tanz.ch>

> ---
>  tools/bpf/bpftool/btf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
> index faac8189b285..c2f1fd414820 100644
> --- a/tools/bpf/bpftool/btf.c
> +++ b/tools/bpf/bpftool/btf.c
> @@ -596,7 +596,7 @@ static int do_dump(int argc, char **argv)
>  			goto done;
>  		}
>  		if (!btf) {
> -			err = ENOENT;
> +			err = -ENOENT;
>  			p_err("can't find btf with ID (%u)", btf_id);
>  			goto done;
>  		}
> -- 
> 2.26.2
>