linux-kernel - [PATCH] btrfs: fix error value in btrfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200803093506.GA19472@amd>
Date:   Mon, 3 Aug 2020 11:35:06 +0200
From:   Pavel Machek <pavel@...x.de>
To:     clm@...com, jbacik@...com, dsterba@...e.com, sashal@...nel.org,
        wqu@...e.com, nborisov@...e.com, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, jungyeon@...ech.edu,
        stable@...nel.org
Subject: [PATCH] btrfs: fix error value in btrfs_get_extent

btrfs_get_extent() sets variable ret, but out: error path expect error
to be in variable err. Fix that.

Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>

---

Notice that patch introducing this problem is on its way to 4.19.137-stable.

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 7befb7c12bd3..4aaa01540f89 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -7012,7 +7012,7 @@ struct extent_map *btrfs_get_extent(struct btrfs_inode *inode,
 	    found_type == BTRFS_FILE_EXTENT_PREALLOC) {
 		/* Only regular file could have regular/prealloc extent */
 		if (!S_ISREG(inode->vfs_inode.i_mode)) {
-			ret = -EUCLEAN;
+			err = -EUCLEAN;
 			btrfs_crit(fs_info,
 		"regular/prealloc extent found for non-regular inode %llu",
 				   btrfs_ino(inode));

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)