lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Aug 2020 18:46:37 -0700 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Song Liu <songliubraving@...com> Cc: open list <linux-kernel@...r.kernel.org>, bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Kernel Team <kernel-team@...com>, john fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, Jesper Dangaard Brouer <brouer@...hat.com>, Daniel Xu <dlxu@...com> Subject: Re: [PATCH bpf-next 4/5] selftests/bpf: move two functions to test_progs.c On Sat, Aug 1, 2020 at 1:50 AM Song Liu <songliubraving@...com> wrote: > > Move time_get_ns() and get_base_addr() to test_progs.c, so they can be > used in other tests. > > Signed-off-by: Song Liu <songliubraving@...com> > --- > .../selftests/bpf/prog_tests/attach_probe.c | 21 ------------- > .../selftests/bpf/prog_tests/test_overhead.c | 8 ----- > tools/testing/selftests/bpf/test_progs.c | 30 +++++++++++++++++++ > tools/testing/selftests/bpf/test_progs.h | 2 ++ > 4 files changed, 32 insertions(+), 29 deletions(-) > [...] > static int test_task_rename(const char *prog) > { > int i, fd, duration = 0, err; > diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c > index b1e4dadacd9b4..c9e6a5ad5b9a4 100644 > --- a/tools/testing/selftests/bpf/test_progs.c > +++ b/tools/testing/selftests/bpf/test_progs.c > @@ -622,6 +622,36 @@ int cd_flavor_subdir(const char *exec_name) > return chdir(flavor); > } > > +__u64 time_get_ns(void) > +{ I'd try to avoid adding stuff to test_progs.c. There is generic testing_helpers.c, maybe let's put this there? > + struct timespec ts; > + > + clock_gettime(CLOCK_MONOTONIC, &ts); > + return ts.tv_sec * 1000000000ull + ts.tv_nsec; > +} > + > +ssize_t get_base_addr(void) > +{ This would definitely be better in trace_helpers.c, though. > + size_t start, offset; > + char buf[256]; > + FILE *f; > + [...]
Powered by blists - more mailing lists