linux-kernel - Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200803071234-mutt-send-email-mst@kernel.org>
Date:   Mon, 3 Aug 2020 07:12:40 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Ashutosh Dixit <ashutosh.dixit@...el.com>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        sudeep.dutt@...el.com, arnd@...db.de, vincent.whitchurch@...s.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()

On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
> 
> 551:58: warning: incorrect type in argument 1 (different address spaces)
> 551:58:    expected void const volatile [noderef] __iomem *addr
> 551:58:    got restricted __le64 *
> 560:49: warning: incorrect type in argument 1 (different address spaces)
> 560:49:    expected struct mic_device_ctrl *dc
> 560:49:    got struct mic_device_ctrl [noderef] __iomem *dc
> 579:49: warning: incorrect type in argument 1 (different address spaces)
> 579:49:    expected struct mic_device_ctrl *dc
> 579:49:    got struct mic_device_ctrl [noderef] __iomem *dc
> 
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Cc: Sudeep Dutt <sudeep.dutt@...el.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Vincent Whitchurch <vincent.whitchurch@...s.com>
> Cc: stable <stable@...r.kernel.org>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@...el.com>

Acked-by: Michael S. Tsirkin <mst@...hat.com>

> ---
>  drivers/misc/mic/vop/vop_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
> index 85942f6717c5..25ed7d731701 100644
> --- a/drivers/misc/mic/vop/vop_main.c
> +++ b/drivers/misc/mic/vop/vop_main.c
> @@ -546,7 +546,7 @@ static int vop_match_desc(struct device *dev, void *data)
>  	return vdev->desc == (void __iomem *)data;
>  }
>  
> -static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl *dc)
> +static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl __iomem *dc)
>  {
>  	return (struct _vop_vdev *)(unsigned long)readq(&dc->vdev);
>  }
> -- 
> 2.26.2.108.g048abe1751