lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Aug 2020 12:05:46 +0800 From: Neal Liu <neal.liu@...iatek.com> To: Chun-Kuang Hu <chunkuang.hu@...nel.org> CC: Neal Liu <neal.liu@...iatek.com>, Rob Herring <robh+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, <devicetree@...r.kernel.org>, wsd_upstream <wsd_upstream@...iatek.com>, lkml <linux-kernel@...r.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver Hi Chun-Kuang, On Sun, 2020-08-02 at 07:50 +0800, Chun-Kuang Hu wrote: > Hi, Neal: > > Neal Liu <neal.liu@...iatek.com> 於 2020年7月29日 週三 下午4:29寫道: > > > > MediaTek bus fabric provides TrustZone security support and data > > protection to prevent slaves from being accessed by unexpected > > masters. > > The security violation is logged and sent to the processor for > > further analysis or countermeasures. > > > > Any occurrence of security violation would raise an interrupt, and > > it will be handled by mtk-devapc driver. The violation > > information is printed in order to find the murderer. > > > > Signed-off-by: Neal Liu <neal.liu@...iatek.com> > > --- > > [snip] > > > + > > +struct mtk_devapc_context { > > + struct device *dev; > > + u32 vio_idx_num; > > + void __iomem *devapc_pd_base; > > This is devapc context, so prefix 'devapc' is redundant. > And, what does 'pd' mean? 'pd' means power down. Of course we would also remove it as well. I suggest to change it as 'infra_base'. > > Regards, > Chun-Kuang. > > > + struct mtk_devapc_vio_info *vio_info; > > + const struct mtk_devapc_pd_offset *offset; > > + const struct mtk_devapc_vio_dbgs *vio_dbgs; > > +}; > > +
Powered by blists - more mailing lists