linux-kernel - Re: [PATCH v3] sched: Provide USF for the portable equipment.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200803150756.GA1098726@kroah.com>
Date:   Mon, 3 Aug 2020 17:07:56 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dongdong Yang <contribute.kernel@...il.com>
Cc:     rjw@...ysocki.net, viresh.kumar@...aro.org, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        devel@...verdev.osuosl.org, gulinghua@...omi.com,
        tanggeliang@...omi.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, yangdongdong@...omi.com,
        duhui@...omi.com, zhangguoquan@...omi.com, fengwei@...omi.com,
        taojun@...omi.com, rocking@...ux.alibaba.com, huangqiwu@...omi.com
Subject: Re: [PATCH v3] sched: Provide USF for the portable equipment.

On Mon, Aug 03, 2020 at 10:31:15PM +0800, Dongdong Yang wrote:
> +	/*
> +	 * create a sched_usf in cpu_subsys:
> +	 * /sys/devices/system/cpu/sched_usf/...

I thought I asked you not to use a "raw" kobject, you are making this
much harder than it has to be.

Just use a normal struct device.

Also you failed to document your new sysfs files in Documentation/ABI/
like is required :(

Because of both of those things, this isn't ok as-is, sorry.

greg k-h