linux-kernel - Re: [PATCH] hwmon: axi-fan-control: remove duplicate macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200804212739.GA218807@roeck-us.net>
Date:   Tue, 4 Aug 2020 14:27:39 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        jdelvare@...e.com, nuno.sa@...log.com
Subject: Re: [PATCH] hwmon: axi-fan-control: remove duplicate macros

On Mon, Aug 03, 2020 at 08:43:11AM +0300, Alexandru Ardelean wrote:
> These macros are also present in the "include/linux/fpga/adi-axi-common.h"
> file which is included in this driver.
> 
> This patch removes them from the AXI Fan Control driver. No sense in having
> them in 2 places.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/axi-fan-control.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
> index 38d9cdb3db1a..e3f6b03e6764 100644
> --- a/drivers/hwmon/axi-fan-control.c
> +++ b/drivers/hwmon/axi-fan-control.c
> @@ -15,10 +15,6 @@
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
>  
> -#define ADI_AXI_PCORE_VER_MAJOR(version)	(((version) >> 16) & 0xff)
> -#define ADI_AXI_PCORE_VER_MINOR(version)	(((version) >> 8) & 0xff)
> -#define ADI_AXI_PCORE_VER_PATCH(version)	((version) & 0xff)
> -
>  /* register map */
>  #define ADI_REG_RSTN		0x0080
>  #define ADI_REG_PWM_WIDTH	0x0084