linux-kernel - Re: [PATCH v6 08/22] bootconfig: init: Allow admin to use bootconfig for init command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200804092913.0d5556f604d141955c53324a@kernel.org>
Date:   Tue, 4 Aug 2020 09:29:13 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Arvind Sankar <nivedita@...m.mit.edu>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Ingo Molnar <mingo@...hat.com>,
        Frank Rowand <frowand.list@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Tim Bird <Tim.Bird@...y.com>, Jiri Olsa <jolsa@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Rob Herring <robh+dt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-doc@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 08/22] bootconfig: init: Allow admin to use
 bootconfig for init command line

On Mon, 3 Aug 2020 13:22:38 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 3 Aug 2020 11:29:59 -0400
> Arvind Sankar <nivedita@...m.mit.edu> wrote:
> 
> > > +	/* parse_args() stops at '--' and returns an address */
> > > +	if (!IS_ERR(err) && err)
> > > +		initargs_found = true;
> > > +  
> > 
> > I think you can drop the second IS_ERR, since we already checked that.
> 
> Masami,
> 
> Can you send this with the update as a normal patch (not a Cc to this
> thread). That way it gets caught by my patchwork scanning of my inbox.

OK, I'll update it.

> 
> Thanks!
> 
> (/me is currently going through all his patchwork patches to pull in
> for the merge window.)

Thank you!

> 
> -- Steve


-- 
Masami Hiramatsu <mhiramat@...nel.org>