linux-kernel - Re: [PATCH v10 4/8] usr: add support for zstd compressed initramfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUo5tfcEUaq4x_b9HJy25HXWmBZ3GPfqJy491zDsct5Rg@mail.gmail.com>
Date:   Tue, 4 Aug 2020 08:52:38 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Nick Terrell <nickrterrell@...il.com>
Cc:     Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Chris Mason <clm@...com>,
        linux-kbuild <linux-kbuild@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Petr Malat <oss@...at.biz>, Kees Cook <keescook@...omium.org>,
        Kernel Team <Kernel-team@...com>,
        Adam Borowski <kilobyte@...band.pl>,
        Patrick Williams <patrickw3@...com>, rmikey@...com,
        Ingo Molnar <mingo@...nel.org>,
        Patrick Williams <patrick@...cx.xyz>,
        Sedat Dilek <sedat.dilek@...il.com>,
        Norbert Lange <nolange79@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Alex Xu <alex_y_xu@...oo.ca>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nick Terrell <terrelln@...com>
Subject: Re: [PATCH v10 4/8] usr: add support for zstd compressed initramfs

Hi Nick,

On Thu, Jul 30, 2020 at 9:13 PM Nick Terrell <nickrterrell@...il.com> wrote:
> From: Nick Terrell <terrelln@...com>
>
> * Add support for a zstd compressed initramfs.
> * Add compression for compressing built-in initramfs with zstd.
>
> I have tested this patch by boot testing with buildroot and QEMU.
> Specifically, I booted the kernel with both a zstd and gzip compressed
> initramfs, both built into the kernel and separate. I ensured that the
> correct compression algorithm was used. I tested on arm, aarch64, i386,
> and x86_64.
>
> This patch has been tested in production on aarch64 and x86_64 devices.
>
> Additionally, I have performance measurements from internal use in
> production. On an aarch64 device we saw 19 second boot time improvement
> from switching from lzma to zstd (27 seconds to 8 seconds). On an x86_64
> device we saw a 9 second boot time reduction from switching from xz to
> zstd.
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
> Tested-by: Sedat Dilek <sedat.dilek@...il.com>
> Signed-off-by: Nick Terrell <terrelln@...com>

Thanks for your patch, which is now commit a30d8a39f0571425 ("usr: Add
support for zstd compressed initramfs").

> --- a/usr/Kconfig
> +++ b/usr/Kconfig
> @@ -100,6 +100,15 @@ config RD_LZ4
>           Support loading of a LZ4 encoded initial ramdisk or cpio buffer
>           If unsure, say N.
>
> +config RD_ZSTD
> +       bool "Support initial ramdisk/ramfs compressed using ZSTD"
> +       default y
> +       depends on BLK_DEV_INITRD
> +       select DECOMPRESS_ZSTD
> +       help
> +         Support loading of a ZSTD encoded initial ramdisk or cpio buffer.
> +         If unsure, say N.

I'm aware you copied this from the other entries, but IMHO "default y",
and "If unsure, say N" are not a good combination.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds