linux-kernel - Re: [net-next v2] seg6: using DSCP of inner IPv4 packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01738166-f784-09f3-2286-150442ffa237@gmail.com>
Date:   Tue, 4 Aug 2020 09:42:07 +0200
From:   Ahmed Abdelsalam <ahabdels@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        andrea.mayer@...roma2.it
Subject: Re: [net-next v2] seg6: using DSCP of inner IPv4 packets

The problem was the declaration of tos.
Fixed and new patch is sent.

On 03/08/2020 21:48, Jakub Kicinski wrote:
> On Mon,  3 Aug 2020 18:14:17 +0000 Ahmed Abdelsalam wrote:
>> This patch allows copying the DSCP from inner IPv4 header to the
>> outer IPv6 header, when doing SRv6 Encapsulation.
>>
>> This allows forwarding packet across the SRv6 fabric based on their
>> original traffic class.
>>
>> Signed-off-by: Ahmed Abdelsalam <ahabdels@...il.com>
> 
> Please make sure it builds cleanly with W=1 C=1:
> 
> net/ipv6/seg6_iptunnel.c:131:21: warning: incorrect type in assignment (different base types)
> net/ipv6/seg6_iptunnel.c:131:21:    expected restricted __be32 [usertype] tos
> net/ipv6/seg6_iptunnel.c:131:21:    got unsigned char
> net/ipv6/seg6_iptunnel.c:133:21: warning: incorrect type in assignment (different base types)
> net/ipv6/seg6_iptunnel.c:133:21:    expected restricted __be32 [usertype] tos
> net/ipv6/seg6_iptunnel.c:133:21:    got unsigned char [usertype] tos
> net/ipv6/seg6_iptunnel.c:144:27: warning: incorrect type in argument 2 (different base types)
> net/ipv6/seg6_iptunnel.c:144:27:    expected unsigned int tclass
> net/ipv6/seg6_iptunnel.c:144:27:    got restricted __be32 [usertype] tos
>